Update home page when language changes #3811

Jack251970 · 2025-07-09T03:22:01Z

Changes

When search is empty and Home Page feature is enabled, if the language is changed, the home page will not be updated by its translation until next non-empty query. So we should check if home page is shown and update the translations

Test

Enable Home Page and change language, the search window results will be updated

Copilot

Pull Request Overview

Ensure the home page translations refresh immediately when the application language changes without requiring a new search query.

Added a conditional check in the language-change handler to trigger a home-page refresh when showing the home page and the query is empty.
Calls _viewModel.QueryResults() to re-render translations on language switch.

Comments suppressed due to low confidence (1)

Flow.Launcher/MainWindow.xaml.cs:287

There are no existing tests covering this new refresh logic. Consider adding a unit or integration test that simulates a language change with an empty query to verify the home page translations update as expected.

                        if (_settings.ShowHomePage && _viewModel.QueryResultsSelected() && string.IsNullOrEmpty(_viewModel.QueryText))

Flow.Launcher/MainWindow.xaml.cs

gitstream-cm · 2025-07-09T03:23:03Z

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
JUL	4 additions & 3 deletions
JUN	91 additions & 71 deletions	87 additions & 18 deletions
MAY	145 additions & 43 deletions	5 additions & 1 deletions
APR	69 additions & 45 deletions	5 additions & 1 deletions
MAR	1141 additions & 1076 deletions	327 additions & 141 deletions
FEB	1 additions & 1 deletions	8 additions & 4 deletions

Knowledge based on git-blame:
Jack251970: 67%
onesounds: 16%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

github-actions · 2025-07-09T03:23:04Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	2
⚠️ non-alpha-in-dictionary	2

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

gitstream-cm · 2025-07-09T03:23:09Z

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
JUL	4 additions & 3 deletions
JUN	91 additions & 71 deletions	87 additions & 18 deletions
MAY	145 additions & 43 deletions	5 additions & 1 deletions
APR	69 additions & 45 deletions	5 additions & 1 deletions
MAR	1141 additions & 1076 deletions	327 additions & 141 deletions
FEB	1 additions & 1 deletions	8 additions & 4 deletions

Knowledge based on git-blame:
Jack251970: 67%
onesounds: 16%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

gitstream-cm · 2025-07-09T03:23:12Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

coderabbitai · 2025-07-09T03:23:16Z

📝 Walkthrough

Walkthrough

A conditional block was added to the _settings.PropertyChanged event handler for the Language property in MainWindow.xaml.cs. When the language changes and certain UI conditions are met, the view model's QueryResults() method is called to refresh the query results display.

Changes

File(s)	Change Summary
Flow.Launcher/MainWindow.xaml.cs	Added logic to refresh query results when the language changes and specific UI conditions are true.

Suggested reviewers

jjw24
taooceros

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f510b1 and b1e352d.

📒 Files selected for processing (1)

Flow.Launcher/MainWindow.xaml.cs (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3118
File: Flow.Launcher/ViewModel/MainViewModel.cs:1404-1413
Timestamp: 2024-12-08T21:12:12.060Z
Learning: In the `MainViewModel` class, the `_lastQuery` field is initialized in the constructor and is never null.

Flow.Launcher/MainWindow.xaml.cs (6)

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3672
File: Flow.Launcher/MainWindow.xaml.cs:244-247
Timestamp: 2025-06-08T14:12:21.348Z
Learning: In Flow.Launcher, App.NotifyIcon is created before MainWindow creation, so null checks for App.NotifyIcon are not necessary when accessing it from MainWindow code.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3672
File: Flow.Launcher/MainWindow.xaml.cs:318-318
Timestamp: 2025-06-08T14:12:12.842Z
Learning: In Flow.Launcher, the App.NotifyIcon static property is initialized in the App class before MainWindow creation, so null checks are not needed when accessing App.NotifyIcon in MainWindow lifecycle methods.

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3118
File: Flow.Launcher/ViewModel/MainViewModel.cs:1404-1413
Timestamp: 2024-12-08T21:12:12.060Z
Learning: In the `MainViewModel` class, the `_lastQuery` field is initialized in the constructor and is never null.

Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in `JsonRPCPluginSettings.cs`), path validation is enabled by default in `OpenFileDialog` and `FolderBrowserDialog`, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

Learnt from: onesounds
PR: Flow-Launcher/Flow.Launcher#3394
File: Flow.Launcher/Themes/Darker Glass.xaml:134-141
Timestamp: 2025-03-28T21:12:13.386Z
Learning: In Flow.Launcher, hotkey styling is implemented with a two-component structure: a Border element with style `ItemHotkeyBGStyle` that provides background and border styling, containing a TextBlock with style `ItemHotkeyStyle` that handles the text styling.

🧬 Code Graph Analysis (1)

Flow.Launcher/MainWindow.xaml.cs (1)

Flow.Launcher/ViewModel/MainViewModel.cs (2)

QueryResultsSelected (1704-1708)

QueryResults (1121-1124)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: gitStream.cm
GitHub Check: gitStream workflow automation
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: Check Spelling
GitHub Check: build

🔇 Additional comments (1)

Flow.Launcher/MainWindow.xaml.cs (1)

287-290: LGTM! Implementation follows existing patterns and addresses the issue correctly.

This change properly addresses the PR objective by refreshing the home page translations when the language changes. The implementation:

Uses the same conditional logic as the existing ShowHomePage/ShowHistoryResultsForHomePage handlers (lines 315-318)

Appropriately checks all necessary conditions before triggering the refresh

Follows the established pattern of calling _viewModel.QueryResults() to update the display

The addition of the _settings.ShowHomePage condition is a good optimization that ensures the refresh only occurs when the home page feature is actually enabled.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gitstream-cm · 2025-07-09T03:23:17Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Flow.Launcher/MainWindow.xaml.cs

Update home page when language changes

…_page Update home page when language changes

Update home page when language changes

b1e352d

Jack251970 requested a review from Copilot July 9, 2025 03:22

prlabeler bot added the enhancement New feature or request label Jul 9, 2025

Jack251970 self-assigned this Jul 9, 2025

Jack251970 added the kind/ui related to UI, icons, themes, etc label Jul 9, 2025

Jack251970 added this to the 2.0.0 milestone Jul 9, 2025

Copilot AI reviewed Jul 9, 2025

View reviewed changes

Flow.Launcher/MainWindow.xaml.cs Show resolved Hide resolved

jjw24 reviewed Jul 10, 2025

View reviewed changes

Flow.Launcher/MainWindow.xaml.cs Show resolved Hide resolved

jjw24 enabled auto-merge July 10, 2025 11:39

jjw24 added bug Something isn't working and removed enhancement New feature or request labels Jul 10, 2025

jjw24 approved these changes Jul 10, 2025

View reviewed changes

jjw24 merged commit 7a031e3 into dev Jul 10, 2025
18 of 19 checks passed

jjw24 deleted the refresh_home_page branch July 10, 2025 11:40

coderabbitai bot mentioned this pull request Jul 13, 2025

Fix Home Page Update Issue #3819

Merged

jjw24 modified the milestones: 2.0.0, 1.20.2 Jul 13, 2025

jjw24 added a commit that referenced this pull request Jul 13, 2025

Merge pull request #3811 from Flow-Launcher/refresh_home_page

1c43e45

Update home page when language changes

jjw24 mentioned this pull request Jul 13, 2025

Release 1.20.2 | Plugin 4.7.0 #3820

Merged

TBM13 pushed a commit to TBM13/Flow.Launcher that referenced this pull request Jul 14, 2025

Merge pull request Flow-Launcher#3811 from Flow-Launcher/refresh_home…

1844cda

…_page Update home page when language changes

Uh oh!

Update home page when language changes #3811

Update home page when language changes #3811

Uh oh!

Conversation

Jack251970 commented Jul 9, 2025

Changes

Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

gitstream-cm bot commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

s.b. workaround(s)

Uh oh!

gitstream-cm bot commented Jul 9, 2025

Uh oh!

gitstream-cm bot commented Jul 9, 2025

Uh oh!

coderabbitai bot commented Jul 9, 2025

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gitstream-cm bot commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)